Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gi-flow #430

Merged
merged 51 commits into from
Nov 20, 2024
Merged

gi-flow #430

merged 51 commits into from
Nov 20, 2024

Conversation

vradulescu-bd
Copy link
Contributor

@vradulescu-bd vradulescu-bd commented Nov 19, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Documentation

  • I have updated the sidekick documentation.
  • I have updated new baselines in GhostInspector.

Test URLs:

@vradulescu-bd vradulescu-bd requested a review from enake as a code owner November 19, 2024 09:53
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 19, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to gi-flow November 19, 2024 09:57 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to gi-flow November 19, 2024 10:03 Inactive
@vradulescu-bd vradulescu-bd added the accept-baselines Flag for accepting new baselines automatically on Ghost Inspector label Nov 19, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to gi-flow November 19, 2024 10:53 Inactive
@vradulescu-bd vradulescu-bd added accept-baselines Flag for accepting new baselines automatically on Ghost Inspector and removed accept-baselines Flag for accepting new baselines automatically on Ghost Inspector labels Nov 19, 2024
@vradulescu-bd vradulescu-bd added accept-baselines Flag for accepting new baselines automatically on Ghost Inspector and removed accept-baselines Flag for accepting new baselines automatically on Ghost Inspector labels Nov 19, 2024
@vradulescu-bd vradulescu-bd added accept-baselines Flag for accepting new baselines automatically on Ghost Inspector and removed accept-baselines Flag for accepting new baselines automatically on Ghost Inspector labels Nov 19, 2024
@vradulescu-bd vradulescu-bd added the accept-baselines Flag for accepting new baselines automatically on Ghost Inspector label Nov 19, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to gi-flow November 19, 2024 12:02 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to gi-flow November 19, 2024 12:12 Inactive
@vradulescu-bd vradulescu-bd added accept-baselines Flag for accepting new baselines automatically on Ghost Inspector and removed accept-baselines Flag for accepting new baselines automatically on Ghost Inspector labels Nov 19, 2024
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@actions-user
Lock for baseline update by PR #430 [skip husky]
1079642
enake
enake previously approved these changes Nov 20, 2024
View reviewed changes
@vradulescu-bd vradulescu-bd added accept-baselines Flag for accepting new baselines automatically on Ghost Inspector and removed accept-baselines Flag for accepting new baselines automatically on Ghost Inspector labels Nov 20, 2024
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@actions-user
Lock for baseline update by PR #430
f5b723d
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@actions-user
Lock for baseline update by PR #430 [skip husky]
eeb6601
@aem-code-sync aem-code-sync bot temporarily deployed to gi-flow November 20, 2024 13:00 Inactive
enake
enake previously approved these changes Nov 20, 2024
View reviewed changes
@vradulescu-bd vradulescu-bd added accept-baselines Flag for accepting new baselines automatically on Ghost Inspector and removed accept-baselines Flag for accepting new baselines automatically on Ghost Inspector labels Nov 20, 2024
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@actions-user
Lock for baseline update by PR #430
ede8e24
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@actions-user
Lock for baseline update by PR #430 [skip husky]
b252248
@vradulescu-bd vradulescu-bd removed the accept-baselines Flag for accepting new baselines automatically on Ghost Inspector label Nov 20, 2024
@vradulescu-bd vradulescu-bd added the accept-baselines Flag for accepting new baselines automatically on Ghost Inspector label Nov 20, 2024
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@actions-user
Lock for baseline update by PR #430
f0ec84c
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@actions-user
Lock for baseline update by PR #430 [skip husky]
e15568e
@github-actions github-actions bot merged commit 75377b1 into main Nov 20, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andserbanbitdefender Andserbanbitdefender Andserbanbitdefender approved these changes

@enake enake enake approved these changes

@ltiseanu ltiseanu ltiseanu left review comments

@inastase inastase inastase left review comments

Assignees
No one assigned
Labels
accept-baselines Flag for accepting new baselines automatically on Ghost Inspector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vradulescu-bd @enake @inastase @ltiseanu @Andserbanbitdefender @actions-user